CI: Check out the correct branch of nuttx repo when compiling nuttx-apps #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thanks @cederom! I'll wait till Oct 30, don't want to mess up our perfect GitHub Runners now :-) |
|
i have restarted the CI for verification :-) |
|
@cederom Thanks! Let's wait for the broken builds to clear, so we won't pile on more problems :-) |
When compiling the Release Branch of `nuttx-apps`, our CI Workflow `build.yml` checks out the Master Branch of `nuttx` repo, which is incorrect. This happens due to a typo in `build.yml`: apache/nuttx#14513 This PR fixes the typo in `build.yml` to checkout the correct branch of `nuttx` repo.
xiaoxiang781216
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When compiling the Release Branch of
nuttx-apps, our CI Workflowbuild.ymlchecks out the Master Branch ofnuttxrepo, which is incorrect. This happens due to a typo inbuild.yml: apache/nuttx#14513This PR fixes the typo in
build.ymlto checkout the correct branch ofnuttxrepo.Impact
When compiling the Release Branch of
nuttx-apps, our CI Workflowbuild.ymlnow checks out the Release Branch ofnuttxrepo.No changes when compiling the Master Branch of
nuttxandnuttx-appsrepos.Testing
Before the PR: Fetch-Source Log shows that CI is incorrectly checking out the Master Branch of
nuttxrepo (instead ofreleases/12.7): https://github.com/apache/nuttx-apps/actions/runs/11518661640/job/32069568370#step:3:66After the PR: When we change
nametoos_ref, CI correctly checks out the Release Branch ofnuttxrepo: https://github.com/lupyuen5/label-nuttx-apps/actions/runs/11528123257/job/32094821811#step:3:57Regression Test: